Blueprint sled editor: don't track decommissioned sleds#9631
Merged
jgallagher merged 2 commits intomainfrom Jan 13, 2026
Merged
Blueprint sled editor: don't track decommissioned sleds#9631jgallagher merged 2 commits intomainfrom
jgallagher merged 2 commits intomainfrom
Conversation
davepacheco
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the small cleanup I mentioned in #9608 (comment). Prior to this PR,
SledEditorwrapped anInnerSledEditorenum with active / decommissioned variants, andSledEditor's methods were mostly just passthroughs to the two inner variants, except for a handful of methods that were only valid for commissioned sleds. After this PR,SledEditoronly handles active sleds, andBlueprintBuilderkeeps a separate set of all the configs for decommissioned sleds. Most of the other changes to the buildprint builder were minor fallout from slight changes (e.g., someSledEditormethods were fallible and now are infallible).