Ensure oximeter schemas do not change #9341
Merged
+65
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davepacheco
reviewed
Nov 5, 2025
Collaborator
davepacheco
left a comment
davepacheco
left a comment
There was a problem hiding this comment.
Cool! That was fast. It'd be good to get a +1 from @bnaecker or @andrewjstone because I don't know what other files might need to be locked down.
| #[tokio::test] | ||
| async fn test_schemas_are_not_modified() -> anyhow::Result<()> { | ||
| let cur_dir = PathBuf::from(env!("CARGO_MANIFEST_DIR")); | ||
| let single_node_schema_checksum = |
Collaborator
There was a problem hiding this comment.
Why checksums here instead of expectorate? Is it to make it harder to override?
bnaecker
approved these changes
Nov 5, 2025
davepacheco
reviewed
Nov 5, 2025
| Similarly, there must be only a single instance of this program at a time. | ||
|
|
||
| _NB: Schema changes for the `oximeter` database are currently disabled due to | ||
| ongoing self-service update work. More information about this restriction can |
Collaborator
There was a problem hiding this comment.
This is alright but this work is not ongoing and not planned. The plan of record is to do nothing until we have a need to change the schema and then figure out how we would automate that kind of change.
Contributor
Author
There was a problem hiding this comment.
argh, sorry! I misread the suggestion and thought it was just a syntax change 🤦♀️ I'll open up another PR with the text change!
karencfv
added a commit
that referenced
this pull request
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #8862