[reconfigurator-planning] add test to ensure DNS lookups work on example system#9233
Conversation
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
davepacheco
left a comment
davepacheco
left a comment
There was a problem hiding this comment.
Thank you for doing this!
|
|
||
| out.insert(ServiceName::CruciblePantry, Ok(())); | ||
|
|
||
| // XXX the SledAgent service name doesn't appear to be used? |
There was a problem hiding this comment.
I think it probably is unused but arguably should be. I think we could incorporate it in the same way that you did for Crucible below.
There was a problem hiding this comment.
Note we don't even register the sled agent service names within blueprint_internal_dns_config today. Have added these to the map with a response of QueryError::NoRecordsFound.
| ); | ||
| } | ||
|
|
||
| // TODO: add assertions on the returned addresses. |
There was a problem hiding this comment.
| // TODO: add assertions on the returned addresses. |
There was a problem hiding this comment.
Do you think we should check that the addresses match what we expect? I kind of skipped over that because I wanted to detect packet fragmentation first.
Created using spr 1.3.6-beta.1
davepacheco
left a comment
davepacheco
left a comment
There was a problem hiding this comment.
Looks great! Thanks for this.
| | ServiceName::CruciblePantry => { | ||
| out.insert(service, Ok(())); | ||
| } | ||
| // Services that are not currently part of the example system. |
There was a problem hiding this comment.
(sorry if we already did this)
Can you file an issue for including these in the example system?
Created using spr 1.3.6-beta.1
sunshowers
deleted the
sunshowers/spr/reconfigurator-planning-add-test-to-ensure-dns-lookups-work-on-example-system
branch
2 participants
Ensure that DNS lookups for all internal services work on the example system, through both the standard and qorb DNS resolvers.
I did notice that the example system doesn't set up every service. Something worth doing in a followup, but this does catch issues like (manually tested) the repo depot response being too large.