Notify sled-agent of firewall rules #465
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NetworkInterfaces always belong to exactly one instance throughout their lifecycle.
This model currently uses randomly generated locally administered MAC addresses. This is probably? not what we want longer term.
|
@rzezeski I need to do further testing on this Thursday, but this branch is the logic for pushing the changes to sled-agent |
After the merge, active_propolis_id was used instead of active_server_id
|
Okay, with the latest version here, a request gets sent to sled_agent with the new firewall rules. We still need to figure out how to apply them |
This is an API we intend to have, but it might not look like this. Having such an API will be useful for testing the network interface logic though.
|
Thanks for all the work here @teisenbe! I'm planning to pick up your baton :) |
|
I believe this is being taken up elsewhere (in existing and/or follow-up PRs). I'm going to close this for now. |
|
I'm picking this up (eventually) in the draft branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This notifies sled-agent when firewall rules are changed. It does not currently send the initial firewall rules to sled-agent when instances are created.