Relocate 'api_identity' derive macro - it's a helper for omicron-common #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davepacheco
approved these changes
Oct 12, 2021
david-crespo
added a commit
that referenced
this pull request
Nov 18, 2021
* Revert "Relocate 'api_identity' derive macro - it's a helper for omicron-common (#288)" This reverts commit ec737d3. * create external_api and internal_api modules, put entrypoints inside * pull project and org views and params out of common * do an example of internal params * update openapi spec fixture * comment symmetry on params files * update comment * address comments
david-crespo
added a commit
that referenced
this pull request
Nov 18, 2021
* Revert "Relocate 'api_identity' derive macro - it's a helper for omicron-common (#288)" This reverts commit ec737d3. * create external_api and internal_api modules, put entrypoints inside * pull project and org views and params out of common * do an example of internal params * update openapi spec fixture * comment symmetry on params files * move sled agent's DiskEnsureBody into sled agent * do a more complicated sled agent type * super::super:: -> crate:: * move bootstrap agent types into bootstrap agent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for cleanup:
omicron-common/src/api/external, so it has beenmoved to be co-located with usage.