Skip to content

[nexus] Support allocating external IP addresses for internal services #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 6, 2022
Merged

[nexus] Support allocating external IP addresses for internal services #1611

merged 6 commits into from
Sep 6, 2022

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented Aug 17, 2022

Extends the allocation of external IPs to also support "service IPs", which are not associated with instances.

  • Modifies the instance_external_ip table to let the project be optional. A "service IP" is one where the project and instance IDs are both "NULL".
  • Modifies the external IP allocation CTE to support this new type of provision.
    • While I was there, fixed the idempotence of provisioniong when out of IP pool space for all external IP allocations.

Part of #1530
Fixes #1610

@smklein smklein requested a review from bnaecker August 17, 2022 05:42
smklein
smklein commented Aug 17, 2022
View reviewed changes
smklein
smklein commented Aug 17, 2022
View reviewed changes
smklein
smklein commented Aug 17, 2022
View reviewed changes
bnaecker
bnaecker reviewed Aug 17, 2022
View reviewed changes
@smklein smklein mentioned this pull request Aug 17, 2022
Closed
bnaecker
bnaecker reviewed Aug 17, 2022
View reviewed changes
bnaecker
bnaecker reviewed Aug 17, 2022
View reviewed changes
bnaecker
bnaecker reviewed Aug 17, 2022
View reviewed changes
Copy link
Collaborator

@bnaecker bnaecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding / fixing the idempotency edge case, and the tests look great! I've got a few questions around constraints and the new IpSource field.

@smklein smklein mentioned this pull request Aug 22, 2022
Merged
@smklein
Copy link
Collaborator Author

smklein commented Aug 22, 2022

Thanks for finding / fixing the idempotency edge case, and the tests look great! I've got a few questions around constraints and the new IpSource field.

All comments addressed - this should be ready for re-review!

@bnaecker bnaecker self-requested a review August 22, 2022 19:44
bnaecker
bnaecker reviewed Aug 23, 2022
View reviewed changes
bnaecker
bnaecker approved these changes Aug 23, 2022
View reviewed changes
Copy link
Collaborator

@bnaecker bnaecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks for taking another pass. Looks great!

@smklein smklein merged commit 628fa2d into main Sep 6, 2022
@smklein smklein deleted the allocate-service-ips branch September 6, 2022 18:06
smklein added a commit that referenced this pull request Sep 6, 2022
@smklein
Rename InstanceExternalIp to ExternalIp (#1635)
c3621ac 
Fixes #1614
Depends on #1611
leftwo pushed a commit that referenced this pull request Jan 28, 2025
Update Propolis and Crucible
add5b7e 
Crucible changes are:
Add early rejection of IOs if too many Downstairs are inactive (#1565)
Fix missing write stats in Oximeter. (#1617)
Shrink replay buffer (#1616)
Update tokio to 1.40 (#1611)

Propolis changes are:
crates: move host CPUID queries from cpuid-gen to cpuid-utils (#843)
@leftwo leftwo mentioned this pull request Jan 28, 2025
Merged
leftwo added a commit that referenced this pull request Jan 29, 2025
@leftwo
Update Propolis and Crucible (#7421)
5fa0d8e 
Crucible changes are:
Add early rejection of IOs if too many Downstairs are inactive (#1565) 
Fix missing write stats in Oximeter. (#1617)
Shrink replay buffer (#1616)
Update tokio to 1.40 (#1611)

Propolis changes are:
crates: move host CPUID queries from cpuid-gen to cpuid-utils (#843)

---------

Co-authored-by: Alan Hanson <alan@oxide.computer>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnaecker bnaecker bnaecker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

External IP allocation is not idempotent when out of addresses
2 participants
@smklein @bnaecker