scrimlet-reconcilers: Add dpd port reconciliation#10449
Open
jgallagher wants to merge 1 commit into
Open
Conversation
Contributor
|
Created oxidecomputer/dendrite#272 for testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR looks big but over 60% of it is tests; the production code that needs careful review is the new
sled-agent/scrimlet-reconcilers/src/dpd_reconciler/port_reconciler.rsmodule. It contains a port of whatsync_switch_reconcilerdoes to configure QSFP ports, with several changes:RackNetworkConfiginstead of the dbdaftdpdissue where ports that change speed or FEC have to be removed before reapplying. @internet-diglett is working on adpdchange that would make this unnecessary, but for now it's easy enough to work around on our side.