Skip to content

audit the permissions required to modify a resource's policy #2303

@davepacheco

Description

@davepacheco

Creating this ticket for

// TODO-security We should carefully review what permissions are
// required for modifying the policy of a resource.

(edit: this comment was removed under #2417 but the issue remains)

Internally, there's an explicit authz action for ModifyPolicy. Who should get it? Right now, it's precisely anyone who can modify the resource:

Action::ModifyPolicy => Perm::Modify,

For resources covered by the roles policy test, you can see which roles are able to modify the resource's policy in this output file (the "MP" column):
https://github.com/oxidecomputer/omicron/blob/b062e95f5f917909b8c6d40200a4d0d80847694f/nexus/tests/output/authz-roles.out

We should make sure that's right.

Metadata

Metadata

Assignees

No one assigned

    Labels

    securityRelated to security.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions