`destroy_virtual_hardware.sh` emits error-looking messages on success

[davepacheco]

On a system where I've never installed Omicron, I ran destroy_virtual_hardware.sh (which I think is supposed to be idempotent):

dap@ivanova omicron-deploy $ pfexec ./tools/destroy_virtual_hardware.sh
+++ dirname ./tools/destroy_virtual_hardware.sh
++ cd ./tools
++ pwd
+ SOURCE_DIR=/home/dap/omicron-deploy/tools
+ cd /home/dap/omicron-deploy/tools/..
+ OMICRON_TOP=/home/dap/omicron-deploy
+ MARKER=/etc/opt/oxide/NO_INSTALL
+ [[ -f /etc/opt/oxide/NO_INSTALL ]]
++ id -u
+ [[ 0 -ne 0 ]]
+ try_remove_vnics
+ try_remove_address lo0/underlay
+ local ADDRESS=lo0/underlay
+ RC=0
++ ipadm show-addr -p -o addr lo0/underlay
ipadm: Address object not found+ [[ -n '' ]]
+ [[ 0 -eq 0 ]]
+ success 'Address lo0/underlay destroyed'
+ echo -e '\e[1;36mAddress lo0/underlay destroyed\e[0m'
Address lo0/underlay destroyed
+ VNIC_LINKS=("net0" "net1")
+ for LINK in "${VNIC_LINKS[@]}"
+ try_remove_vnic net0
+ local LINK=net0
+ RC=0
++ dladm show-vnic -p -o LINK net0
dladm: invalid vnic name 'net0': object not found
+ [[ -n '' ]]
+ [[ 0 -eq 0 ]]
+ success 'VNIC link net0 destroyed'
+ echo -e '\e[1;36mVNIC link net0 destroyed\e[0m'
VNIC link net0 destroyed
+ for LINK in "${VNIC_LINKS[@]}"
+ try_remove_vnic net1
+ local LINK=net1
+ RC=0
++ dladm show-vnic -p -o LINK net1
dladm: invalid vnic name 'net1': object not found
+ [[ -n '' ]]
+ [[ 0 -eq 0 ]]
+ success 'VNIC link net1 destroyed'
+ echo -e '\e[1;36mVNIC link net1 destroyed\e[0m'
VNIC link net1 destroyed
+ try_destroy_zpools
+ readarray -t ZPOOLS
++ zfs list -d 0 -o name
++ grep '^oxp_'

There are a bunch of error-looking messages in there and it's not super clear whether things are okay in the current state. (I gather that they are. The two kinds of messages here are reporting things are destroyed that actually never existed and reporting that certain objects are not found that it would have removed anyway. But it's not obvious this is okay unless you already know what this script does and how.)

[bnaecker]

Resolved by #1352