Allow configuring model and serial number per node #292
+29
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is primarily useful in a4x2 to populate the smbios with information that matches the platform id of certificates used by sprockets.
rcgoodfellow
approved these changes
Nov 23, 2025
Collaborator
rcgoodfellow
left a comment
rcgoodfellow
left a comment
There was a problem hiding this comment.
LGTM, thanks!. Just need to bump the propolis ref as noted below.
| slog-envlogger = "2.2" | ||
| toml = "0.9" | ||
| propolis-client = { git = "https://github.com/oxidecomputer/propolis", rev = "3f1752e6cee9a2f8ecdce6e2ad3326781182e2d9" } | ||
| propolis-client = { git = "https://github.com/oxidecomputer/propolis", rev = "9d82bd4fb3e5840c8c8f506d7016dcc7cf3eb52c" } |
Collaborator
There was a problem hiding this comment.
We'll need to update this to a ref on main once oxidecomputer/propolis#976 lands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is primarily useful in a4x2 to populate the smbios with information that matches the platform id of certificates used by sprockets.