Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
- Gate per-resource actions with capability helpers: `instanceCan.start(instance)`, `diskCan.delete(disk)`, etc. (`app/api/util.ts:91-207`)—these return booleans and have `.states` properties listing valid states. Always use these instead of inline state checks; they centralize business logic and link to Omicron source explaining restrictions.
- Pass `disabledReason` prop (accepts ReactNode) when disabling buttons so the UI explains why the action is unavailable.


# Upgrading pinned omicron version

1. Update commit hash in `OMICRON_VERSION`.
Expand Down
1 change: 0 additions & 1 deletion app/api/__tests__/safety.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ it('mock-api is only referenced in test files', () => {
"app/main.tsx",
"app/msw-mock-api.ts",
"docs/mock-api-differences.md",
"mock-api/msw/util.ts",
"package.json",
"test/e2e/utils.ts",
"test/unit/server.ts",
Expand Down
2 changes: 1 addition & 1 deletion app/forms/floating-ip-edit.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ import { IpPoolCell } from '~/table/cells/IpPoolCell'
import { CopyableIp } from '~/ui/lib/CopyableIp'
import { PropertiesTable } from '~/ui/lib/PropertiesTable'
import { ALL_ISH } from '~/util/consts'
import { pb } from '~/util/path-builder'
import type * as PP from '~/util/path-params'
import { pb } from 'app/util/path-builder'

const floatingIpView = ({ project, floatingIp }: PP.FloatingIp) =>
apiq('floatingIpView', { path: { floatingIp }, query: { project } })
Expand Down
4 changes: 3 additions & 1 deletion app/pages/project/instances/NetworkingTab.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,9 @@ const staticCols = [
header: 'Transit IPs',
cell: (info) => (
<ListPlusCell tooltipTitle="Other transit IPs">
{info.getValue()?.map((ip) => <div key={ip}>{ip}</div>)}
{info.getValue()?.map((ip) => (
<div key={ip}>{ip}</div>
))}
</ListPlusCell>
),
}),
Expand Down
2 changes: 1 addition & 1 deletion mock-api/msw/util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import { differenceInSeconds, subHours } from 'date-fns'
// Works without the .js for dev server and prod build in MSW mode, but
// playwright wants the .js. No idea why, let's just add the .js.
import { IPv4, IPv6 } from 'ip-num/IPNumber.js'
import { getMockOxqlInstanceData } from 'mock-api/oxql-metrics'

import {
FLEET_ID,
Expand All @@ -34,6 +33,7 @@ import { GiB, TiB } from '~/util/units'

import type { DbRoleAssignmentResourceType } from '..'
import { genI64Data } from '../metrics'
import { getMockOxqlInstanceData } from '../oxql-metrics'
import { db } from './db'
import { Rando } from './rando'

Expand Down
Loading
Loading