Skip to content

Fix date picker re-renders by breaking debounce loop #2874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-crespo merged 1 commit into from
Aug 6, 2025
Merged

Fix date picker re-renders by breaking debounce loop #2874

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions app/components/form/fields/DateTimeRangePicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,15 @@ export function useDateTimeRangePicker({
items,
}

const [startTime] = useDebounce(range.start.toDate(tz), 400)
const [endTime] = useDebounce(range.end.toDate(tz), 400)
// Without these useMemos, we get re-renders every 400ms because when the
// debounce timeout expires, it updates the value, which triggers a render for
// itself because the time gets remade by toDate() (i.e., even though it is
// the same time, it is a new object)
const rangeStart = useMemo(() => range.start.toDate(tz), [range.start])
const [startTime] = useDebounce(rangeStart, 400)

const rangeEnd = useMemo(() => range.end.toDate(tz), [range.end])
const [endTime] = useDebounce(rangeEnd, 400)

return {
startTime,
Expand Down
Loading