Add IP pool name to Attach Floating IP dropdown #2870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
|
I think this is handy. My only concern is that it may not be clear that it's a pool name when the name doesn't have the word "pool" in it. But I'm not sure how much we can do about that without bloating the line with "pool:" or something. @benjaminleonard? 
|
Contributor
|
Yeah, I think it's probably just a compromise we have to make due to the limited space |
Collaborator
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Aug 20, 2025
oxidecomputer/console@777a959...8cc5b25 * [8cc5b253](oxidecomputer/console@8cc5b253) oxidecomputer/console#2891 * [33b2b55c](oxidecomputer/console@33b2b55c) oxidecomputer/console#2890 * [41ed7e3a](oxidecomputer/console@41ed7e3a) oxidecomputer/console#2882 * [887a2cab](oxidecomputer/console@887a2cab) oxidecomputer/console#2870 * [76ca8cff](oxidecomputer/console@76ca8cff) oxidecomputer/console#2879
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Aug 20, 2025
oxidecomputer/console@777a959...8cc5b25 * [8cc5b253](oxidecomputer/console@8cc5b253) oxidecomputer/console#2891 * [33b2b55c](oxidecomputer/console@33b2b55c) oxidecomputer/console#2890 * [41ed7e3a](oxidecomputer/console@41ed7e3a) oxidecomputer/console#2882 * [887a2cab](oxidecomputer/console@887a2cab) oxidecomputer/console#2870 * [76ca8cff](oxidecomputer/console@76ca8cff) oxidecomputer/console#2879
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds context to the selector dropdown users interact with when attaching a floating IP to an instance. Specifically, it adds the floating IP's associated IP pool to the information available in the dropdown.
Closes #2869