Skip to content

Add text-raise class to FieldLabels #2799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-crespo merged 3 commits into from
Apr 10, 2025
Merged

Add text-raise class to FieldLabels #2799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c52240
Add text-raise class to FieldLabels
charliepark Apr 9, 2025
a4b10d1
use text-raise on form meta label on auto restart settings
david-crespo Apr 10, 2025
cdacdc1
one more: metadata source on idp create
david-crespo Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/forms/idp/shared.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export function MetadataSourceField({
} = useController({ control, name: 'idpMetadataSource' })
return (
<fieldset>
<legend id="metadata-source-legend" className="mb-2 text-sans-md">
<legend id="metadata-source-legend" className="mb-2 text-sans-md text-raise">
Metadata source
</legend>
{/* TODO: probably need some help text here */}
Expand Down
2 changes: 1 addition & 1 deletion app/pages/project/instances/AutoRestartCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ type FormMetaProps = {

const FormMeta = ({ label, tip, children }: FormMetaProps) => (
<div>
<div className="mb-2 flex items-center gap-1 border-b pb-2 text-sans-md border-secondary">
<div className="mb-2 flex items-center gap-1 border-b pb-2 text-sans-md text-raise border-secondary">
<div>{label}</div>
{tip && <TipIcon>{tip}</TipIcon>}
</div>
Expand Down
6 changes: 5 additions & 1 deletion app/ui/lib/FieldLabel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,11 @@ export const FieldLabel = ({
const Component = as || 'label'
return (
<div className={cn(className, 'flex h-4 items-center space-x-2')}>
<Component id={id} className="flex items-center text-sans-md" htmlFor={htmlFor}>
<Component
id={id}
className="flex items-center text-sans-md text-raise"
htmlFor={htmlFor}
>
{children}
{optional && (
// Announcing this optional text is unnecessary as the required attribute on the
Expand Down
Loading