Disable add-instance-to-anti-affinity-group when instance not stopped #2790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
force-pushed
the
disable-add-instance-when-not-stopped
branch
from
0295694 to
26f96b6
Compare
david-crespo
force-pushed
the
disable-add-instance-when-not-stopped
branch
from
26f96b6 to
96a67b9
Compare
david-crespo
reviewed
Apr 9, 2025
| addToAntiAffinityGroup: ['stopped'], | ||
| // check to see that there's no VMM | ||
| // https://github.com/oxidecomputer/omicron/blob/c496683/nexus/db-queries/src/db/datastore/affinity.rs#L1025-L1034 | ||
| addToAffinityGroup: ['stopped'], |
Collaborator
There was a problem hiding this comment.
renamed because this will be the same for both kinds of group
david-crespo
approved these changes
Apr 9, 2025
Collaborator
david-crespo
left a comment
david-crespo
left a comment
There was a problem hiding this comment.
Merging for now because I am like 90% confident the stopped thing is correct even though we don't have confirmation yet
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 9, 2025
oxidecomputer/console@3e5a0a1...d906190 * [d9061901](oxidecomputer/console@d9061901) oxidecomputer/console#2795 * [8e509d99](oxidecomputer/console@8e509d99) oxidecomputer/console#2793 * [2ef6e7a1](oxidecomputer/console@2ef6e7a1) oxidecomputer/console#2790 * [04aceb5a](oxidecomputer/console@04aceb5a) oxidecomputer/console#2789 * [1ecc5690](oxidecomputer/console@1ecc5690) oxidecomputer/console#2791
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 9, 2025
oxidecomputer/console@3e5a0a1...3db0150 * [3db0150d](oxidecomputer/console@3db0150d) oxidecomputer/console#2796 * [d9061901](oxidecomputer/console@d9061901) oxidecomputer/console#2795 * [8e509d99](oxidecomputer/console@8e509d99) oxidecomputer/console#2793 * [2ef6e7a1](oxidecomputer/console@2ef6e7a1) oxidecomputer/console#2790 * [04aceb5a](oxidecomputer/console@04aceb5a) oxidecomputer/console#2789 * [1ecc5690](oxidecomputer/console@1ecc5690) oxidecomputer/console#2791
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 9, 2025
oxidecomputer/console@3e5a0a1...3db0150 * [3db0150d](oxidecomputer/console@3db0150d) oxidecomputer/console#2796 * [d9061901](oxidecomputer/console@d9061901) oxidecomputer/console#2795 * [8e509d99](oxidecomputer/console@8e509d99) oxidecomputer/console#2793 * [2ef6e7a1](oxidecomputer/console@2ef6e7a1) oxidecomputer/console#2790 * [04aceb5a](oxidecomputer/console@04aceb5a) oxidecomputer/console#2789 * [1ecc5690](oxidecomputer/console@1ecc5690) oxidecomputer/console#2791
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An instance can only be added to an anti-affinity group if that instance is stopped.
We tried a few treatments to the "add an instance to this anti-affinity group" modal, but they were all rather awkward.
runStategot really noisy.We decided to list all of the instances not currently in the anti-affinity group, and to disable the submit button if a non-stopped instance were selected.