Skip to content

minor: longer timeout on image upload cancel state expect #2688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-crespo merged 1 commit into from
Feb 11, 2025
Merged

minor: longer timeout on image upload cancel state expect #2688

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/e2e/image-upload.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,9 +139,9 @@ test.describe('Image upload', () => {
const progressModal = page.getByRole('dialog', { name: 'Image upload progress' })
await expect(progressModal).toBeVisible()

// wait to be in the middle of upload
// wait to be in the middle of the specified step
const uploadStep = page.getByTestId(`upload-step: ${state}`)
await expect(uploadStep).toHaveAttribute('data-status', 'running')
await expect(uploadStep).toHaveAttribute('data-status', 'running', { timeout: 10000 })

// form is disabled and semi-hidden
// await expectNotVisible(page, ['role=textbox[name="Name"]'])
Expand Down
Loading