Remove footer when side modal is read-only #2621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Dec 13, 2024
oxidecomputer/console@927c8b6...2b0c3f1 * [2b0c3f12](oxidecomputer/console@2b0c3f12) oxidecomputer/console#2621 * [c1fbf631](oxidecomputer/console@c1fbf631) oxidecomputer/console#2622 * [1dd25f63](oxidecomputer/console@1dd25f63) oxidecomputer/console#2615 * [11486f8b](oxidecomputer/console@11486f8b) oxidecomputer/console#2620 * [ada302ce](oxidecomputer/console@ada302ce) oxidecomputer/console#2488 * [bc3161ae](oxidecomputer/console@bc3161ae) minor: remove stub e2e test * [9e1d53c6](oxidecomputer/console@9e1d53c6) sentence case idp form heading * [aaf1154f](oxidecomputer/console@aaf1154f) add extra assert for instance create with additional disks test flake * [79d610dc](oxidecomputer/console@79d610dc) oxidecomputer/console#2618 * [bdbc02b7](oxidecomputer/console@bdbc02b7) oxidecomputer/console#2589 * [7a8ee0ab](oxidecomputer/console@7a8ee0ab) oxidecomputer/console#2614 * [0b5220a1](oxidecomputer/console@0b5220a1) npm audit fix * [0c873cf4](oxidecomputer/console@0c873cf4) oxidecomputer/console#2610 * [d031c8ff](oxidecomputer/console@d031c8ff) bump playwright for navigation hang fix * [dbd8545e](oxidecomputer/console@dbd8545e) oxidecomputer/console#2609 * [dc5562fe](oxidecomputer/console@dc5562fe) move error log to avoid failing to log certain errors
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Dec 13, 2024
oxidecomputer/console@927c8b6...c1ebd8d * [c1ebd8d9](oxidecomputer/console@c1ebd8d9) take inventory switches tab back out, DB is empty * [2a139028](oxidecomputer/console@2a139028) tone down empty switches table message * [2b0c3f12](oxidecomputer/console@2b0c3f12) oxidecomputer/console#2621 * [c1fbf631](oxidecomputer/console@c1fbf631) oxidecomputer/console#2622 * [1dd25f63](oxidecomputer/console@1dd25f63) oxidecomputer/console#2615 * [11486f8b](oxidecomputer/console@11486f8b) oxidecomputer/console#2620 * [ada302ce](oxidecomputer/console@ada302ce) oxidecomputer/console#2488 * [bc3161ae](oxidecomputer/console@bc3161ae) minor: remove stub e2e test * [9e1d53c6](oxidecomputer/console@9e1d53c6) sentence case idp form heading * [aaf1154f](oxidecomputer/console@aaf1154f) add extra assert for instance create with additional disks test flake * [79d610dc](oxidecomputer/console@79d610dc) oxidecomputer/console#2618 * [bdbc02b7](oxidecomputer/console@bdbc02b7) oxidecomputer/console#2589 * [7a8ee0ab](oxidecomputer/console@7a8ee0ab) oxidecomputer/console#2614 * [0b5220a1](oxidecomputer/console@0b5220a1) npm audit fix * [0c873cf4](oxidecomputer/console@0c873cf4) oxidecomputer/console#2610 * [d031c8ff](oxidecomputer/console@d031c8ff) bump playwright for navigation hang fix * [dbd8545e](oxidecomputer/console@dbd8545e) oxidecomputer/console#2609 * [dc5562fe](oxidecomputer/console@dc5562fe) move error log to avoid failing to log certain errors
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Dec 14, 2024
oxidecomputer/console@927c8b6...c1ebd8d * [c1ebd8d9](oxidecomputer/console@c1ebd8d9) take inventory switches tab back out, DB is empty * [2a139028](oxidecomputer/console@2a139028) tone down empty switches table message * [2b0c3f12](oxidecomputer/console@2b0c3f12) oxidecomputer/console#2621 * [c1fbf631](oxidecomputer/console@c1fbf631) oxidecomputer/console#2622 * [1dd25f63](oxidecomputer/console@1dd25f63) oxidecomputer/console#2615 * [11486f8b](oxidecomputer/console@11486f8b) oxidecomputer/console#2620 * [ada302ce](oxidecomputer/console@ada302ce) oxidecomputer/console#2488 * [bc3161ae](oxidecomputer/console@bc3161ae) minor: remove stub e2e test * [9e1d53c6](oxidecomputer/console@9e1d53c6) sentence case idp form heading * [aaf1154f](oxidecomputer/console@aaf1154f) add extra assert for instance create with additional disks test flake * [79d610dc](oxidecomputer/console@79d610dc) oxidecomputer/console#2618 * [bdbc02b7](oxidecomputer/console@bdbc02b7) oxidecomputer/console#2589 * [7a8ee0ab](oxidecomputer/console@7a8ee0ab) oxidecomputer/console#2614 * [0b5220a1](oxidecomputer/console@0b5220a1) npm audit fix * [0c873cf4](oxidecomputer/console@0c873cf4) oxidecomputer/console#2610 * [d031c8ff](oxidecomputer/console@d031c8ff) bump playwright for navigation hang fix * [dbd8545e](oxidecomputer/console@dbd8545e) oxidecomputer/console#2609 * [dc5562fe](oxidecomputer/console@dc5562fe) move error log to avoid failing to log certain errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #2619, we don't need to include the footer in a sidemodal when it's read-only.
The Footer currently holds the close button, so we need to move that out to the main form component.
Here's how a read-only side modal looks before this fix:
And after:
Forms with an onSubmit are not affected:
Closes #2619