Internet gateways modal tweak #2607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
benjaminleonard
commented
Dec 6, 2024
| {gatewayIpAddresses.map((gatewayIpAddress) => ( | ||
| <Table.Row key={gatewayIpAddress.id}> | ||
| <Table.Cell className="w-1/2"> | ||
| <Truncate text={gatewayIpAddress.name} maxLength={24} /> |
Contributor
Author
There was a problem hiding this comment.
Could get rid of this and let the table be scrollable, but I think we need an action col on the end to stop it looking funky
benjaminleonard
commented
Dec 6, 2024
| </Table.Body> | ||
| </Table> | ||
| ) : ( | ||
| <EmptyCell /> |
Contributor
Author
There was a problem hiding this comment.
Need to add a proper empty state
david-crespo
force-pushed
the
internet-gateways-modal-tweak
branch
from
b56f528 to
eb14ac1
Compare
charliepark
approved these changes
Dec 6, 2024
Contributor
charliepark
left a comment
charliepark
left a comment
There was a problem hiding this comment.
Solid; thank you for getting this!
david-crespo
added a commit
that referenced
this pull request
Dec 13, 2024
* Update OMICRON_VERSION * update msw handlers * Other changes from initial branch * IP Pools tab in place * IP Pool ID is copyable from IP Pools tab * Add content to IP Addresses tab and root page * Update OMICRON_VERSION to sha with internet gateways * small tweaks * remove commented-out code * Use proper truncate component * adjust path-builder spec * Add breadcrumb nav for internet gateways * Update default internet gateway IP pool to reflect actual default values * update unrelated test * Remove n+1 query on IpPools * Add IpPoolCell * Remove code that we'll add separately * Upgrade OMICRON_VERSION * No need to extract UtilizationCell now * Get IP Pool tab for Internet Gateways working * Update snapshot, but there might still be some other issues to work out * Some headway, but screen is still blank * Update snapshots for test * Update routes; fix mock data * update tests with mock data, but this should probably get pulled to a new branch * Simplify mock data; renaming the default IP Pool to default was unnecessary and confusing * convert to new useQueryTable * Add internet gateway combobox to router route target field * Sidebar for Internet Gateway coming together * Bot commit: format with prettier * DOM shuffling * Update mock data * Update routes to handle new sidebar and main tab together * Reorder internet gateway sidebar * Update paths and snapshots * use more common internet-gateway-edit syntax for filename * Internet gateways modal tweak (#2607) Internet gateway modal tweaks * Add IP Address and IP Pool columns to Gateway table * test update * small tweaks to sidebar * reverting back to vertical table for now, to render IP Pool alonside join table info * Update copy when missing pool or ip address * Add a test for internet gateway list and sidemodal * Add routes targeting gateway to table * Better handle multiple route spacing; fix test * Update side modal with routes targeting gateway * Update test for showing route * Tweaks to sidemodal * move example gateway route to custom router, not default router * Update tests to reflect gateway route existing on custom router * use more specific params in queries * use titleCrumb for Edit Internet Gateway * fix RR leaf route without element warning * let's use a valid UUID * clean up InternetGatewayRoutes and call it as a component * update the snapshot! * fix gnarly dependent promises in gateways loader * update read only info box * clean up gateway routes fetch logic by extracting shared hook * extract gateway data logic into a separate file * Use count of routes; link to sidemodal * Use count of 0 instead of EmptyCell for route count * use EmptyCell for zero routes, copy tweaks, sentence case * sentence case idp form heading * minor: remove stub e2e test --------- Co-authored-by: David Crespo <david.crespo@oxidecomputer.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Benjamin Leonard <benji@oxide.computer>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.