Cleaner useApi hook, remove method name hack #222
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #209
Slight change to the calling API for
useApiData:No difference in type safety.
datastill gets the right type. But we get rid of two different hacks:api, which made me want to cryPlus we don't have to import or call
apieither because the hook wraps it!Next
One quirk right now is that for empty params objects, you need to pass an empty object, which feels silly.
On the other hand there won't like be many of those because we'll be passing the optional page param pretty much all the time.