Skip to content

Upgrade to React Router 6.11.2 #1509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 19, 2023
Merged

Upgrade to React Router 6.11.2 #1509

merged 6 commits into from
May 19, 2023

Conversation

david-crespo
Copy link
Collaborator

This should be trivial, but it's not because:

  1. They rewrote how scroll restore works a bit, so our patch letting us restore scroll on something other than window needed to be rewritten
  2. I wanted to use a ref instead of an ID, following Allow scrolling of individual elements remix-run/react-router#10468, which is itself rework of my PR useElementScrollRestoration remix-run/react-router#9573
  3. I wanted to investigate Scroll restoration on back nav no longer works #1372, which is still a problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant