Instance disk metrics tab returns "something went wrong" error

[askfongjojo]

This error happens after the metrics API responses have returned:

I do not see any error on nexus side which is consistent with the 200 responses I see on the browser console. Invoking some of the metrics queries using CLI also works for me:

$ oxide experimental timeseries query --query '{get virtual_disk:bytes_written; get virtual_disk:bytes_read } | filter timestamp > @now() - 30s| filter disk_id == "d8986332-65e3-43f0-a471-7366b2f1b5dc"' --project angela
{
  "tables": [
    {
      "name": "virtual_disk:bytes_written",
      "timeseries": {
        "17139298291928455619": {
          "fields": {
            "disk_id": {
              "type": "uuid",
              "value": "d8986332-65e3-43f0-a471-7366b2f1b5dc"
            },
            "silo_id": {
              "type": "uuid",
              "value": "7bd7623a-68ed-4636-8ecb-b59e3b068787"
            },
            "attached_instance_id": {
              "type": "uuid",
              "value": "3fbff45c-cf48-4dfd-9dc8-a4be0402e13a"
            },
            "project_id": {
              "type": "uuid",
              "value": "fe0da422-5c48-4b52-8010-f2fc401f090f"
            },
            "block_size": {
              "type": "u32",
              "value": 4096
            }
          },
          "points": {
            "start_times": [
              "2025-02-13T07:27:30.655996275Z",
              "2025-02-13T07:57:09.094344498Z",
              "2025-02-13T07:57:19.093842194Z"
            ],
            "timestamps": [
              "2025-02-13T07:57:09.094344498Z",
              "2025-02-13T07:57:19.093842194Z",
              "2025-02-13T07:57:29.094288161Z"
            ],
            "values": [
              {
                "metric_type": "delta",
                "values": {
                  "type": "integer",
                  "values": [
                    14655488,
                    245760,
                    49152
                  ]
                }
              }
            ]
          }
        }
      }
    },
    {
      "name": "virtual_disk:bytes_read",
      "timeseries": {
        "17139298291928455619": {
          "fields": {
            "silo_id": {
              "type": "uuid",
              "value": "7bd7623a-68ed-4636-8ecb-b59e3b068787"
            },
            "disk_id": {
              "type": "uuid",
              "value": "d8986332-65e3-43f0-a471-7366b2f1b5dc"
            },
            "attached_instance_id": {
              "type": "uuid",
              "value": "3fbff45c-cf48-4dfd-9dc8-a4be0402e13a"
            },
            "project_id": {
              "type": "uuid",
              "value": "fe0da422-5c48-4b52-8010-f2fc401f090f"
            },
            "block_size": {
              "type": "u32",
              "value": 4096
            }
          },
          "points": {
            "start_times": [
              "2025-02-13T07:27:30.655996275Z",
              "2025-02-13T07:57:09.094158697Z",
              "2025-02-13T07:57:19.093646123Z"
            ],
            "timestamps": [
              "2025-02-13T07:57:09.094158697Z",
              "2025-02-13T07:57:19.093646123Z",
              "2025-02-13T07:57:29.094093763Z"
            ],
            "values": [
              {
                "metric_type": "delta",
                "values": {
                  "type": "integer",
                  "values": [
                    64421888,
                    0,
                    0
                  ]
                }
              }
            ]
          }
        }
      }
    }
  ]
}

[benjaminleonard]

Console is expecting timestamp as a date – and the part of the generator that automatically parses it is not recognising the string as a date because the regex is expecting upto 6 decimals and the timestamps have 9.

https://github.com/oxidecomputer/oxide.ts/blob/c513dccfeef3e7ff2453f0b922d8a896d3017611/oxide-api/src/util.ts#L48

const isoDateRegex = /^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}(\.\d{1,6})?Z$/;