Skip to content

Use disabled icon for "disabled" VPC firewall rules #2397

Description

@charliepark

Right now both "enabled" and "disabled" have a check icon. We should update the disabled one to … something else. CC @benjaminleonard

Screenshot 2024-08-26 at 3 17 29 PM

Activity

  1. benjaminleonard commented on Aug 27, 2024

    @benjaminleonard
    Contributor

    See equivalent design for disks. If that isn't already using this icon it should also be:

    image
  2. changed the title [-]New icon for "disabled" state for VPC firewall rules[/-] [+]Use disabled icon for "disabled" VPC firewall rules[/+] on Aug 27, 2024
  3. added this to the Unscheduled milestone on Aug 27, 2024
  4. charliepark commented on Aug 27, 2024

    @charliepark
    ContributorAuthor

    There are a number of other disk state options … are there specific icons we should be using for the other states? Or we could lean on <Success12Icon> and <Disabled12Icon> for attached/detached, and anything else gets <Info12Icon> for now?

  5. benjaminleonard commented on Aug 27, 2024

    @benjaminleonard
    Contributor

    Good point, might be worthwhile adding some other roundels to account for all of them. Mind adding that as an issue and I'll get to mapping existing icons and creating any new ones if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions