feat: support IncludeValue for get operation#207
Merged
mattisonchao merged 6 commits intomainfrom Mar 11, 2025
Merged
Conversation
mattisonchao
requested review from
RobertIndie,
coderzc and
merlimat
as code owners
mattisonchao
changed the title
IncludeValue for get operation
heesung-sohn
approved these changes
Mar 6, 2025
heesung-sohn
left a comment
heesung-sohn
left a comment
There was a problem hiding this comment.
Lgtm. Is this backward compatible?
coderzc
approved these changes
Mar 6, 2025
merlimat
reviewed
Mar 6, 2025
| * @return A GetOption instance representing the include value setting. | ||
| */ | ||
| static GetOption IncludeValue(boolean includeValue) { | ||
| return new OptionIncludeValue(includeValue); |
Collaborator
There was a problem hiding this comment.
We could use 2 static objects here instead of allocating new object each time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
See oxia-db/oxia#636