-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] The Everything Refactor #2212
Open
dr7ana
wants to merge
312
commits into
dev
Choose a base branch
from
quic-wip
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagerman
changed the title
[WIP] Messaging Refactor
[WIP] Messaging Refactor (general quicwip branch PR)
Nov 27, 2023
Closed
- message transmission routed through refactored handling - still work to be done, but now to make it compile at least
- almost all errors have been commented out for refactor or already refactored - committing this prior to sorting out the cmake structure - upcoming include-what-you-use application
- Get rid of CryptoManager. - Get rid of Crypto. - Move all the Crypto instance methods to llarp::crypto functions. (None of them needed to be methods at all, so this is simple). - Move sodium/ntru initialization into static initialization. - Add llarp::csrng, which is an available llarp::CSRNG instance which is a bit easier than needing to construct a `CSRNG rng{};` in various places. - Various related small simplifications/cleanups.
- includes are now sorted in consistent, logical order; first step in an attempt to fix the tomfoolery (no relation to Tom) brought in by include-what-you-use - shuffled around some cmake linking to simplify dependency graph - superfluous files removed
As long as it's loaded before oxen-mq or libquic, this should end up being the one that gets used in oxen-mq/libquic, and so we don't have to update those when we want something in a newer oxen-encoding.
- cleaned up include-what-you-use errors (mostly quoted includes) - misc fixes
They aren't useful right now.
Also deliberately don't provide the function at all if we aren't compiled with libcrypt so that we can't link if we try to call it when not available.
There are some bugfix releases, but also the upstream hash was wrong for the current release anyway (upstream changed it?).
- some weird function call business - string formatting - etc
This was causing cmake to double-invoke ccache for compilation units, and broke oxen-mq's local zmq build for the same reason.
Use backports for cmake because ngtcp2 needs 3.20+.
- Packets coming in and out of full clients need their IP src/dest addresses re-written - Lokinet's TUN device sucks up all packets aimed at the if range, correctly addressing them to the proper outbound - On reception, lokinet's TUN device addresses correctly for the mapped application receiving the packet - Brought a lil somethin' somethin' from libquic for CI - Bump oxenmq to cpp20 branch - Revert cpr to 1.9 stable for subproject curl dep bug
- libevent loop ticker now handles all execution of `Router::tick()`
- Formatting concept to enable oxen-logging printing for custom objects was updated with libquic vbump to require boolean member variable - Members added in base objects to be inherited through
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This PR is tracking all of the experimental code going in for the quic refactor; it will eventually move to
dev
once it works again, but is just here to track the branch until then).