Eol_compat: fix crash triggered by ocamlgrammarfuzzer#128
Open
let-def wants to merge 1 commit into
Open
Conversation
Here is a sample sentence triggering the problem:
object method ! x1 : type x2 . x3 * {%ext|s|} = X4 end
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eol_compatassumes that the excluded locations are non‑overlapping and strictly increasing. This assumption does not hold in all cases, as illustrated by the following sentence:The proposed change does not introduce a regression: it only triggers for situations that were not previously covered. However, I do not fully understand
Eol_compat, so I cannot guarantee that it behaves as intended on sentences that were failing before.This fix is a prerequisite for integrating the fuzzer, because the current issue makes
ocamlformatcrash and prevents further analysis. (Exceptions are usually caught by theocamlformatdriver and turned into an error message, not this one.)