Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(wasm): check wasm32-wasip1-threads build #9569

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Mar 5, 2025

Duplicate of #9555, but just stacked on top of #9566.

napi-rs for some reason omits the export * from '@oxc-project/types'; line from index.d.ts when building for WASM.

I don't know how to fix that, so added a hacky script to fix up index.d.ts manually. This is not at all ideal, but at least it now compiles and CI passes.

Copy link
Contributor Author

overlookmotel commented Mar 5, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel force-pushed the 03-05-ci_wasm_check_wasm32-wasip1-threads_build branch from b9f5155 to da13261 Compare March 5, 2025 16:40
@overlookmotel overlookmotel marked this pull request as ready for review March 5, 2025 16:50
@overlookmotel overlookmotel requested a review from Boshen March 5, 2025 22:49
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Mar 6, 2025
Copy link
Member

Boshen commented Mar 6, 2025

Merge activity

  • Mar 5, 8:33 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 5, 8:33 PM EST: A user added this pull request to the Graphite merge queue.
  • Mar 5, 8:40 PM EST: A user merged this pull request with the Graphite merge queue.

Duplicate of #9555, but just stacked on top of #9566.

`napi-rs` for some reason omits the `export * from '@oxc-project/types';` line from `index.d.ts` when building for WASM.

I don't know how to fix that, so added a hacky script to fix up `index.d.ts` manually. This is not at all ideal, but at least it now compiles and CI passes.
@graphite-app graphite-app bot force-pushed the 03-05-fix_napi_do_not_support_raw_transfer_on_wasm32 branch from 10ed2d0 to 91c9932 Compare March 6, 2025 01:34
@graphite-app graphite-app bot force-pushed the 03-05-ci_wasm_check_wasm32-wasip1-threads_build branch from da13261 to 2985bf3 Compare March 6, 2025 01:34
Base automatically changed from 03-05-fix_napi_do_not_support_raw_transfer_on_wasm32 to main March 6, 2025 01:39
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 6, 2025
@graphite-app graphite-app bot merged commit 2985bf3 into main Mar 6, 2025
22 checks passed
@graphite-app graphite-app bot deleted the 03-05-ci_wasm_check_wasm32-wasip1-threads_build branch March 6, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants