Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(oxc_macros): remove commented-out unused code #8896

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

shulaoda
Copy link
Member

@shulaoda shulaoda commented Feb 4, 2025

  • Add line breaks to What it does and Why is this bad? comments for consistency with Examples
  • Remove commented-out unused code

Copy link

graphite-app bot commented Feb 4, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Feb 4, 2025
Copy link

codspeed-hq bot commented Feb 4, 2025

CodSpeed Performance Report

Merging #8896 will not alter performance

Comparing shulaoda:chore/remove-comments (cf46465) with main (a302e32)

Summary

✅ 33 untouched benchmarks

@Boshen Boshen merged commit 5b548a1 into oxc-project:main Feb 8, 2025
26 checks passed
@shulaoda shulaoda deleted the chore/remove-comments branch February 8, 2025 18:04
Dunqing pushed a commit that referenced this pull request Feb 10, 2025
- Add line breaks to `What it does` and `Why is this bad?` comments for
consistency with `Examples`
- Remove commented-out unused code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants