Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transformer/private-methods): fix panic if instance private accessor in class #8362

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(transformer/private-methods): fix panic if instance private acces…
…sor in class (#8362)

Fix panic if a private accessor is present in class which also has property. e.g.:

```js
let C = class C {
  prop = 1;
  accessor #private = 2;
};
```

Panic occurred due to trying to unwrap `brand` property, but it's `None` because no private instance methods in the class.
  • Loading branch information
overlookmotel committed Jan 9, 2025
commit ac72adbadef1c123c16abc7e526b1ae8d13d7f21
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,11 @@ impl<'a> ClassProperties<'a, '_> {
let mut weakmap_symbol_id = None;
let mut has_method = false;
exprs.extend(private_props.values().filter_map(|prop| {
if prop.is_method() || prop.is_accessor {
if prop.is_accessor {
return None;
}

if prop.is_method() {
if prop.is_static || has_method {
return None;
}
Expand Down
Loading