-
-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ast)!: no unneccesary trailing underscores on AstBuilder
method names
#8283
refactor(ast)!: no unneccesary trailing underscores on AstBuilder
method names
#8283
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #8283 will not alter performanceComparing Summary
|
Merge activity
|
…ethod names (#8283) `AstBuilder` method names have an `_` added on end if method name is not a valid identifier (e.g. `super`). But no need for trailing underscore on `alloc_super`. Currently this only applies to `super`. But future-proof by checking against all Rust's reserved words. This is a breaking change, because `alloc_super` method was previously called `alloc_super_`. But probably no-one uses that method anyway - usually you'd use `expression_super` method to get an `Expression::Super`.
9bd7cde
to
0db2a22
Compare
9c884f1
to
d8b27af
Compare
AstBuilder
method names have an_
added on end if method name is not a valid identifier (e.g.super
). But no need for trailing underscore onalloc_super
.Currently this only applies to
super
. But future-proof by checking against all Rust's reserved words.This is a breaking change, because
alloc_super
method was previously calledalloc_super_
. But probably no-one uses that method anyway - usually you'd useexpression_super
method to get anExpression::Super
.