Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(linter): rename flat.rs to config.rs #8033

Merged

Conversation

camc314
Copy link
Contributor

@camc314 camc314 commented Dec 19, 2024

simply renames flat.rs to config.rs to more accurately reflect the file's purpose

Copy link
Contributor Author

camc314 commented Dec 19, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 19, 2024
@camc314 camc314 changed the title refactor(linter): renamce flat.rs to config.rs refactor(linter): rename flat.rs to config.rs Dec 19, 2024
@camc314 camc314 marked this pull request as ready for review December 19, 2024 22:45
Copy link

codspeed-hq bot commented Dec 19, 2024

CodSpeed Performance Report

Merging #8033 will not alter performance

Comparing c/12-19-refactor_linter_renamce_flat.rs_to_config.rs_ (952d7e4) with main (2736657)

Summary

✅ 29 untouched benchmarks

@camc314 camc314 force-pushed the c/12-19-refactor_linter_renamce_flat.rs_to_config.rs_ branch from 73d39ed to f6523f6 Compare December 19, 2024 22:54
@camc314 camc314 force-pushed the c/12-19-refactor_linter_simplify_configstore_to_prep_for_nested_configs branch from d17c142 to e4118f5 Compare December 20, 2024 19:53
@camc314 camc314 force-pushed the c/12-19-refactor_linter_renamce_flat.rs_to_config.rs_ branch from f6523f6 to 0487198 Compare December 20, 2024 19:53
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Dec 21, 2024
Copy link
Member

Boshen commented Dec 21, 2024

Merge activity

  • Dec 20, 9:01 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 20, 9:01 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 20, 9:08 PM EST: A user merged this pull request with the Graphite merge queue.

simply renames `flat.rs` to `config.rs` to more accurately reflect the file's purpose
@Boshen Boshen force-pushed the c/12-19-refactor_linter_simplify_configstore_to_prep_for_nested_configs branch from e4118f5 to 50848ed Compare December 21, 2024 02:01
@Boshen Boshen force-pushed the c/12-19-refactor_linter_renamce_flat.rs_to_config.rs_ branch from 0487198 to 952d7e4 Compare December 21, 2024 02:02
Base automatically changed from c/12-19-refactor_linter_simplify_configstore_to_prep_for_nested_configs to main December 21, 2024 02:06
@graphite-app graphite-app bot merged commit 952d7e4 into main Dec 21, 2024
26 checks passed
@graphite-app graphite-app bot deleted the c/12-19-refactor_linter_renamce_flat.rs_to_config.rs_ branch December 21, 2024 02:08
Boshen added a commit that referenced this pull request Dec 30, 2024
## [0.15.4] - 2024-12-30

### Features

- 47cea9a linter: Implement `eslint/no-extra-label` (#8181) (Anson
Heung)
- ef76e28 linter: Implement `eslint/no-multi-assign` (#8158) (Anson
Heung)
- 384858b linter: Implement `jsx-a11y/no-noninteractive-tabindex`
(#8167) (Tyler Earls)
- afc21a6 linter: Implement `eslint/vars-on-top` (#8157) (Yuichiro
Yamashita)
- 65796c4 linter: Implement `eslint/prefer-rest-params` (#8155)
(Yuichiro Yamashita)
- 5234d96 linter: Implement `eslint/no-nested-ternary` (#8150) (Yuichiro
Yamashita)
- 1c5db72 linter: Implement eslint/no-labels (#8131) (Anson Heung)
- 0b04288 linter: Move `import/named` to nursery (#8068) (Boshen)

### Bug Fixes

- 0794bee editor/vscode: Set minimum supported ver. to `^1.93.0` (#8182)
(Pavel Smirnov)
- f3050d4 linter: Exclude svelte files from `no_unused_vars` rule
(#8170) (Yuichiro Yamashita)
- faf7464 linter: Disable rule `react/rules-of-hook` by file extension
(#8168) (Alexander S.)
- 1171e00 linter: Disable `react/rules-of-hooks` for vue and svelte
files (#8165) (Alexander S.)
- 1b9a5ba linter: False positiver in private member expr in
oxc/const-comparison (#8164) (camc314)
- 6bd9ddb linter: False positive in `typescript/ban-tslint-comment`
(#8094) (dalaoshu)
- 10a1fd5 linter: Rule: `no-restricted-imports` support option
`patterns` with `group` key (#8050) (Alexander S.)
- b3f38ae linter: Rule `no-restricted-imports`: support option
`allowImportNames` (#8002) (Alexander S.)
- 340cc90 linter: Rule `no-restricted-imports`: fix option "importNames"
(#7943) (Alexander S.)
- ec2128e linter: Fix line calculation for `eslint/max-lines` in
diagnostics (#7962) (Dmitry Zakharov)
- 79af100 semantic: Reference flags not correctly resolved when after an
export stmt (#8134) (camc314)

### Performance

- d8d2ec6 linter: Run rules which require typescript syntax only when
source type is actually typescript (#8166) (Alexander S.)
- 2736657 semantic: Allocate `UnresolvedReferences` in allocator (#8046)
(Boshen)

### Refactor

- de8246b language_server: Move structs into own file (#8026) (Alexander
S.)
- 774babb linter: Read `exported_bindings_from_star_export` lazily
(#8062) (Boshen)
- 547c102 linter: Use `RwLock<FxHashMap>` instead of `FxDashMap` for
module record data (#8061) (Boshen)
- 952d7e4 linter: Rename `flat.rs` to `config.rs` (#8033) (camc314)
- 50848ed linter: Simplify `ConfigStore` to prep for nested configs
(#8032) (camc314)
- b2a4a78 linter: Remove unused `with_rules` and `set_rule` methods
(#8029) (camc314)
- 6da0b21 oxlint: Remove unused `git.rs` (#7990) (Boshen)
- 58e7777 oxlint: Remove extra if check in `Walkdir` (#7989) (Boshen)
- 02f968d semantic: Change `Bindings` to a plain `FxHashMap` (#8019)
(Boshen)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants