Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(language_server): add capabilities struct #7906

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

Sysix
Copy link
Collaborator

@Sysix Sysix commented Dec 15, 2024

vscode test from local,
intellij test from #7445 (comment)

Copy link

graphite-app bot commented Dec 15, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 15, 2024
Copy link

codspeed-hq bot commented Dec 15, 2024

CodSpeed Performance Report

Merging #7906 will not alter performance

Comparing Sysix:refactor-add-capabilities-struct (5b24369) with main (02b653c)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen requested a review from nrayburn-tech December 15, 2024 04:26
Copy link
Collaborator

@nrayburn-tech nrayburn-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the two minor comments. Not a big deal to change or not change.

crates/oxc_language_server/src/capabilities.rs Outdated Show resolved Hide resolved
@Boshen Boshen merged commit e2b6233 into oxc-project:main Dec 16, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants