Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(transformer): duplicate_expression do not produce temp var for super #7757

Merged
merged 1 commit into from
Dec 10, 2024
Merged

refactor(transformer): duplicate_expression do not produce temp var for super #7757

merged 1 commit into from
Dec 10, 2024

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Dec 9, 2024 •
edited
Loading

TransformCtx::duplicate_expression method introduced in #7754 don't create a temp var for super. This prepares it for use in logical assignment operator transform (#7745).

This was referenced Dec 9, 2024
Merged
Merged
Merged
@overlookmotel Graphite App
Copy link
Contributor Author

overlookmotel commented Dec 9, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Dec 9, 2024
Merged
Merged
Merged
Merged
@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 9, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 9, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #7757 will not alter performance

Comparing 12-09-refactor_transformer_duplicate_expression_do_not_produce_temp_var_for_super_ (9c2a1b6) with main (3c1b2bf)

Summary

✅ 29 untouched benchmarks

@overlookmotel overlookmotel marked this pull request as ready for review December 9, 2024 22:08
@overlookmotel overlookmotel mentioned this pull request Dec 10, 2024
Merged
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 10, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 10, 2024 •
edited
Loading

Merge activity

@overlookmotel
refactor(transformer): duplicate_expression do not produce temp var…
9c2a1b6 
… for `super` (#7757)

`TransformCtx::duplicate_expression` method introduced in #7754 don't create a temp var for `super`. This prepares it for use in logical assignment operator transform (#7745).
@Dunqing Dunqing force-pushed the 12-09-refactor_transformer_duplicate_expression_take_mutated_symbol_needs_temp_var_param branch from 04f6445 to a750ebc Compare December 10, 2024 02:29
@Dunqing Dunqing requested a review from Boshen as a code owner December 10, 2024 02:29
@Dunqing Dunqing force-pushed the 12-09-refactor_transformer_duplicate_expression_do_not_produce_temp_var_for_super_ branch from 5e49bbd to 9c2a1b6 Compare December 10, 2024 02:30
Base automatically changed from 12-09-refactor_transformer_duplicate_expression_take_mutated_symbol_needs_temp_var_param to main December 10, 2024 02:50
@graphite-app graphite-app bot merged commit 9c2a1b6 into main Dec 10, 2024
28 checks passed
@graphite-app graphite-app bot deleted the 12-09-refactor_transformer_duplicate_expression_do_not_produce_temp_var_for_super_ branch December 10, 2024 02:53
@oxc-bot oxc-bot mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

@Boshen Boshen Awaiting requested review from Boshen

Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@overlookmotel