refactor(transformer/class-properties): prefer contains to intersects for bitflags
#7747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-transformer
|
Tiny change to code I wrote originally, so merging without review. |
Merge activity
|
…cts` for bitflags (#7747) Tiny refactor. `contains` is clearer than `intersects`, and they produce equivalent assembly when argument is a single flag value, and statically knowable. https://godbolt.org/z/bTdfbv3f8
overlookmotel
force-pushed
the
12-09-refactor_transformer_class-properties_prefer_contains_to_intersects_for_bitflags
branch
from
c617bd9 to
7e0f7eb
Compare
graphite-app
bot
deleted the
12-09-refactor_transformer_class-properties_prefer_contains_to_intersects_for_bitflags
branch
CodSpeed Performance ReportMerging #7747 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny refactor.
containsis clearer thanintersects, and they produce equivalent assembly when argument is a single flag value, and statically knowable.https://godbolt.org/z/bTdfbv3f8