Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(traverse): document soundness hole #7515

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Nov 27, 2024

Document the remaining (small) soundness hole in Traverse.

Copy link

graphite-app bot commented Nov 27, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

overlookmotel commented Nov 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-docs Category - Documentation. Related to user-facing or internal documentation label Nov 27, 2024
@overlookmotel overlookmotel marked this pull request as ready for review November 27, 2024 17:52
@overlookmotel overlookmotel force-pushed the 11-27-docs_traverse_document_soundness_hole branch from 18a793d to fca5938 Compare November 27, 2024 17:53
Copy link

codspeed-hq bot commented Nov 27, 2024

CodSpeed Performance Report

Merging #7515 will not alter performance

Comparing 11-27-docs_traverse_document_soundness_hole (d351b3e) with main (6e48059)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 28, 2024
Copy link
Member

Boshen commented Nov 28, 2024

Merge activity

  • Nov 27, 8:18 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 27, 8:18 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 27, 8:30 PM EST: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 11-18-fix_traverse_remove_unsound_apis branch from 28a8277 to 84e1bf6 Compare November 28, 2024 01:18
@Boshen Boshen requested a review from Dunqing as a code owner November 28, 2024 01:18
Boshen pushed a commit that referenced this pull request Nov 28, 2024
Document the remaining (small) soundness hole in `Traverse`.
@Boshen Boshen force-pushed the 11-27-docs_traverse_document_soundness_hole branch from fca5938 to 0518f2d Compare November 28, 2024 01:19
Document the remaining (small) soundness hole in `Traverse`.
@Boshen Boshen force-pushed the 11-18-fix_traverse_remove_unsound_apis branch from 84e1bf6 to 5143bb8 Compare November 28, 2024 01:20
@github-actions github-actions bot added A-minifier Area - Minifier A-transformer Area - Transformer / Transpiler labels Nov 28, 2024
@Boshen Boshen force-pushed the 11-27-docs_traverse_document_soundness_hole branch from 0518f2d to d351b3e Compare November 28, 2024 01:21
Base automatically changed from 11-18-fix_traverse_remove_unsound_apis to main November 28, 2024 01:27
@graphite-app graphite-app bot merged commit d351b3e into main Nov 28, 2024
28 checks passed
@graphite-app graphite-app bot deleted the 11-27-docs_traverse_document_soundness_hole branch November 28, 2024 01:30
Boshen pushed a commit that referenced this pull request Nov 28, 2024
Document the remaining (small) soundness hole in `Traverse`.
@oxc-bot oxc-bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier A-transformer Area - Transformer / Transpiler C-docs Category - Documentation. Related to user-facing or internal documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants