Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language_server): calculate correct column when Unicode chars #7484

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

Sysix
Copy link
Contributor

@Sysix Sysix commented Nov 25, 2024

Before:
grafik

After:
grafik

Closes #3625

Copy link

graphite-app bot commented Nov 25, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-bug Category - Bug labels Nov 25, 2024
@Sysix Sysix marked this pull request as ready for review November 25, 2024 22:10
@Sysix Sysix requested a review from nrayburn-tech November 25, 2024 22:11
@Boshen Boshen merged commit 571d7e2 into oxc-project:main Nov 26, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-editor Area - Editor and Language Server C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix calculating source line/column in language server
2 participants