refactor(semantic): always use SymbolFlags::Function for function id

[Dunqing]

close #7402
related: #7470

The purpose of this PR is to keep the SymbolFlags of the function consistent.

Always use SymbolFlags::Function for the function id symbol, to avoid adding extra logic to find accurate SymbolFlags for the function in transformer. This change adds a fallback redeclaration check for case async function foo() {}; var foo; in SemanticBuilder::check_redeclaraion.

No performance difference here because redeclaration is always rare.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[Dunqing]

• refactor(semantic): always use SymbolFlags::Function for function id #7479 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #7479 will not alter performance

_{Comparing 11-26-refactor_semantic_keep_consistent_symbolflags_for_function_id (2fb06c0) with main (6655345)}

Summary

✅ 30 untouched benchmarks

[Boshen]

Merge activity

• Nov 28, 5:54 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Nov 29, 12:14 AM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
• Nov 29, 12:14 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

[overlookmotel]

Can we possibly discuss this before merging? Personally, I'm not convinced this is a good idea.

[Boshen]

oxc/crates/oxc_transformer/src/es2017/async_to_generator.rs

Lines 368 to 373 in 58a125f

	// TODO: Needs a better way to handle the function SymbolFlags in different ModuleKind.
	let flags = if self.ctx.source_type.is_module() && ctx.current_scope_flags().is_top() {
	SymbolFlags::BlockScopedVariable | SymbolFlags::Function
	} else {
	SymbolFlags::FunctionScopedVariable
	};