Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] feat(minifier): minimize logical expression #7179

Conversation

7086cmd
Copy link
Contributor

@7086cmd 7086cmd commented Nov 6, 2024

Not sure about side effects, so let's draft it at first.

Copy link

graphite-app bot commented Nov 6, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-minifier Area - Minifier label Nov 6, 2024
Copy link
Contributor Author

7086cmd commented Nov 6, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @7086cmd and the rest of your teammates on Graphite Graphite

@7086cmd 7086cmd force-pushed the 11-07-_draft_feat_minifier_minimize_logical_expression branch 2 times, most recently from d6008af to ef14ee7 Compare November 6, 2024 16:37
Copy link

codspeed-hq bot commented Nov 6, 2024

CodSpeed Performance Report

Merging #7179 will not alter performance

Comparing 11-07-draft_feat_minifier_minimize_logical_expression (c033958) with 11-06-refactor_minifier_prefer_map_and_and_then (a5bda4e)

Summary

✅ 30 untouched benchmarks

@7086cmd
Copy link
Contributor Author

7086cmd commented Nov 6, 2024

the current behavior is wrong. It should only used in condition checking.

@7086cmd 7086cmd force-pushed the 11-06-refactor_minifier_prefer_map_and_and_then_ branch from a5bda4e to fa5d761 Compare November 9, 2024 10:48
@7086cmd 7086cmd force-pushed the 11-07-_draft_feat_minifier_minimize_logical_expression branch from ef14ee7 to dee999d Compare November 9, 2024 10:48
@7086cmd 7086cmd force-pushed the 11-06-refactor_minifier_prefer_map_and_and_then_ branch from fa5d761 to ec477df Compare November 9, 2024 10:49
@7086cmd 7086cmd force-pushed the 11-07-_draft_feat_minifier_minimize_logical_expression branch from dee999d to c033958 Compare November 9, 2024 10:49
@7086cmd
Copy link
Contributor Author

7086cmd commented Nov 9, 2024

Should change structure. Handle it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-minifier Area - Minifier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant