Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast): change plain_function to accept FunctionBody as a required parameter #6709

Draft
wants to merge 1 commit into
base: 10-21-refactor_traverse_change_generate_uid_in_based_on_node_to_accept_a_generic_type_parameter_as_node_type
Choose a base branch
from

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Oct 20, 2024

No description provided.

Copy link

graphite-app bot commented Oct 20, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Dunqing commented Oct 20, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added A-ast Area - AST A-transformer Area - Transformer / Transpiler labels Oct 20, 2024
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Oct 20, 2024
Copy link

codspeed-hq bot commented Oct 20, 2024

CodSpeed Performance Report

Merging #6709 will not alter performance

Comparing 10-21-refactor_ast_change_plain_function_to_accept_functionbody_as_a_required_parameter (645ff26) with 10-21-refactor_traverse_change_generate_uid_in_based_on_node_to_accept_a_generic_type_parameter_as_node_type (ed15664)

Summary

✅ 30 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant