Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minifier): implement calculations for NumberValue #6419

Merged

Conversation

7086cmd
Copy link
Contributor

@7086cmd 7086cmd commented Oct 10, 2024

No description provided.

Copy link

graphite-app bot commented Oct 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@7086cmd 7086cmd requested a review from Boshen October 10, 2024 11:19
@7086cmd 7086cmd added the A-minifier Area - Minifier label Oct 10, 2024 — with Graphite App
Copy link
Contributor Author

7086cmd commented Oct 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @7086cmd and the rest of your teammates on Graphite Graphite

@7086cmd 7086cmd marked this pull request as ready for review October 10, 2024 11:19
Copy link

codspeed-hq bot commented Oct 10, 2024

CodSpeed Performance Report

Merging #6419 will not alter performance

Comparing 10-10-feat_minifier_implement_calculations_for_numbervalue (ebbf77d) with main (73d6a4a)

Summary

✅ 29 untouched benchmarks

@7086cmd 7086cmd force-pushed the 10-10-feat_minifier_implement_calculations_for_numbervalue branch 2 times, most recently from 1ec9d67 to 2170df0 Compare October 10, 2024 11:32
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 10, 2024
Copy link
Member

Boshen commented Oct 10, 2024

Merge activity

  • Oct 10, 7:48 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 10, 7:48 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 10, 7:52 AM EDT: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 10-10-feat_minifier_implement_calculations_for_numbervalue branch from 2170df0 to ebbf77d Compare October 10, 2024 11:48
@graphite-app graphite-app bot merged commit ebbf77d into main Oct 10, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 10-10-feat_minifier_implement_calculations_for_numbervalue branch October 10, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants