Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(isolated-declarations): mark return struct as non exhaustive #6374

Conversation

DonIsaac
Copy link
Collaborator

@DonIsaac DonIsaac commented Oct 8, 2024

This will let us add fields to IsolatedDeclarationsReturn in the future without breaking consuming code.

Copy link

graphite-app bot commented Oct 8, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

DonIsaac commented Oct 8, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-isolated-declarations Isolated Declarations label Oct 8, 2024
@DonIsaac DonIsaac added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Oct 8, 2024 — with Graphite App
@DonIsaac DonIsaac marked this pull request as ready for review October 8, 2024 17:23
Copy link

codspeed-hq bot commented Oct 8, 2024

CodSpeed Performance Report

Merging #6374 will not alter performance

Comparing don/10-08-refactor_isolated-declarations_mark_return_struct_as_non_exhaustive (a504f96) with main (15dfc1d)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 9, 2024
Copy link

graphite-app bot commented Oct 9, 2024

Merge activity

  • Oct 8, 9:38 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 8, 9:38 PM EDT: Boshen added this pull request to the Graphite merge queue.
  • Oct 8, 9:53 PM EDT: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Spell Check').
  • Oct 8, 10:02 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 8, 10:07 PM EDT: DonIsaac merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the don/10-08-refactor_isolated-declarations_mark_return_struct_as_non_exhaustive branch from 8c25949 to f5116d7 Compare October 9, 2024 01:50
Boshen pushed a commit that referenced this pull request Oct 9, 2024
…#6374)

This will let us add fields to `IsolatedDeclarationsReturn` in the future without breaking consuming code.
Boshen pushed a commit that referenced this pull request Oct 9, 2024
…#6374)

This will let us add fields to `IsolatedDeclarationsReturn` in the future without breaking consuming code.
@Boshen Boshen force-pushed the don/10-08-refactor_isolated-declarations_mark_return_struct_as_non_exhaustive branch from f5116d7 to d7a834d Compare October 9, 2024 01:51
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 9, 2024
…#6374)

This will let us add fields to `IsolatedDeclarationsReturn` in the future without breaking consuming code.
@DonIsaac DonIsaac force-pushed the don/10-08-refactor_isolated-declarations_mark_return_struct_as_non_exhaustive branch from d7a834d to a504f96 Compare October 9, 2024 02:02
@DonIsaac DonIsaac added the 0-merge Merge with Graphite Merge Queue label Oct 9, 2024
@graphite-app graphite-app bot merged commit a504f96 into main Oct 9, 2024
27 checks passed
@graphite-app graphite-app bot deleted the don/10-08-refactor_isolated-declarations_mark_return_struct_as_non_exhaustive branch October 9, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-isolated-declarations Isolated Declarations C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants