Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isolated-declarations): impl Default for options #6372

Conversation

DonIsaac
Copy link
Collaborator

@DonIsaac DonIsaac commented Oct 8, 2024

Makes using ID options more ergonomic.

Copy link
Collaborator Author

DonIsaac commented Oct 8, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite Graphite

Copy link

graphite-app bot commented Oct 8, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@DonIsaac DonIsaac marked this pull request as ready for review October 8, 2024 17:12
Copy link

codspeed-hq bot commented Oct 8, 2024

CodSpeed Performance Report

Merging #6372 will create unknown performance changes

Comparing don/10-08-feat_isolated-declarations_impl_default_for_options (15dfc1d) with main (834ee2a)

Summary

🆕 29 new benchmarks

Benchmarks breakdown

Benchmark main don/10-08-feat_isolated-declarations_impl_default_for_options Change
🆕 codegen[checker.ts] N/A 21 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 72.8 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 399.6 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 24.3 µs N/A
🆕 lexer[antd.js] N/A 22.3 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.5 ms N/A
🆕 lexer[checker.ts] N/A 13.3 ms N/A
🆕 lexer[pdf.mjs] N/A 3.6 ms N/A
🆕 linter[cal.com.tsx] N/A 1.3 s N/A
🆕 linter[checker.ts] N/A 2.4 s N/A
🆕 minifier[antd.js] N/A 349.6 ms N/A
🆕 minifier[react.development.js] N/A 2.5 ms N/A
🆕 minifier[typescript.js] N/A 452.4 ms N/A
🆕 parser[RadixUIAdoptionSection.jsx] N/A 80 µs N/A
🆕 parser[antd.js] N/A 108.6 ms N/A
🆕 parser[cal.com.tsx] N/A 25 ms N/A
🆕 parser[checker.ts] N/A 53.9 ms N/A
🆕 parser[pdf.mjs] N/A 17.7 ms N/A
🆕 semantic[RadixUIAdoptionSection.jsx] N/A 99.1 µs N/A
🆕 semantic[antd.js] N/A 118.9 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 9, 2024
Copy link

graphite-app bot commented Oct 9, 2024

Merge activity

  • Oct 8, 9:35 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 8, 9:35 PM EDT: Boshen added this pull request to the Graphite merge queue.
  • Oct 8, 9:49 PM EDT: Boshen merged this pull request with the Graphite merge queue.

Makes using ID options more ergonomic.
@Boshen Boshen force-pushed the don/10-08-feat_isolated-declarations_impl_default_for_options branch from 4210c8b to 15dfc1d Compare October 9, 2024 01:43
@graphite-app graphite-app bot merged commit 15dfc1d into main Oct 9, 2024
26 checks passed
@graphite-app graphite-app bot deleted the don/10-08-feat_isolated-declarations_impl_default_for_options branch October 9, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-isolated-declarations Isolated Declarations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants