Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): implement no-return-assign #6108

Merged
merged 3 commits into from
Sep 27, 2024
Merged

feat(linter): implement no-return-assign #6108

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5d55ee
feat(linter): implement no-return-assign
radu2147 Sep 26, 2024
29a265b
Address review comments
radu2147 Sep 27, 2024
2debcf1
Update crates/oxc_linter/src/rules/eslint/no_return_assign.rs
radu2147 Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update crates/oxc_linter/src/rules/eslint/no_return_assign.rs 
Co-authored-by: Cameron <cameron.clark@hey.com>
  • Loading branch information
@radu2147 @camc314
radu2147 and camc314 authored Sep 27, 2024
commit 2debcf1069e22469919adbf62b80a0d8605cb21f
4 changes: 2 additions & 2 deletions crates/oxc_linter/src/rules/eslint/no_return_assign.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ declare_oxc_lint!(
/// function x() { var result = a = b; return result; }
/// ```
NoReturnAssign,
style, // See <https://oxc.rs/docs/contribute/linter.html#rule-category> for details
suggestion // Options are 'fix', 'fix_dangerous', 'suggestion', and 'conditional_fix_suggestion'
style,
suggestion
);

fn is_sentinel_node(ast_kind: AstKind) -> bool {
Expand Down