Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): implement no-dupe-args #486

Closed
wants to merge 2 commits into from

Conversation

cijiugechu
Copy link
Contributor

related issue #479

@Boshen
Copy link
Member

Boshen commented Jun 27, 2023

This rule disallows duplicate parameter names in function declarations or expressions. It does not apply to arrow functions or class methods, because the parser reports the error.

If ESLint parses code in strict mode, the parser (instead of this rule) reports the error.

We need to only enable this when it's not strict mode. I'll add in the relevant code tomorrow.

@Boshen
Copy link
Member

Boshen commented Jun 28, 2023

It just occurred to me that this rule is in the same vein as no-with and no-octal. Oxc runs all files under strict mode so this rule is a thing of the past.

I'm really said that I didn't cross it out and you worked on this :-( Please forgive me.

@cijiugechu cijiugechu closed this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants