fix(linter/no-unused-vars): do not delete function expressions when fixing #4848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 12, 2024
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
DonIsaac
force-pushed
the
don/08-10-refactor_linter/no-unused-vars_split_fixer_logic
branch
from
0d48c22 to
415cf78
Compare
DonIsaac
force-pushed
the
don/08-10-fix_linter/no-unused-vars_do_not_delete_function_expressions_when_fixing
branch
from
5fc4653 to
4dcf620
Compare
DonIsaac
force-pushed
the
don/08-10-refactor_linter/no-unused-vars_split_fixer_logic
branch
from
415cf78 to
ad3ddee
Compare
DonIsaac
force-pushed
the
don/08-10-fix_linter/no-unused-vars_do_not_delete_function_expressions_when_fixing
branch
from
4dcf620 to
ed50d5b
Compare
CodSpeed Performance ReportMerging #4848 will not alter performanceComparing Summary
|
|
Looks like same as #4445 (comment) ? |
Merge activity
|
…ixing (#4848) `VariableDeclarator` fixer will no longer delete declarations that are initialized to function expressions. ```ts // none of these get deleted const unusedArrow = () => {} const unusedAnon = function() {} const unusedNamed = function foo() {} // matches fixer behavior for function declarations function unusedDecl() {} ```
Boshen
force-pushed
the
don/08-10-refactor_linter/no-unused-vars_split_fixer_logic
branch
from
ad3ddee to
c53c210
Compare
Boshen
force-pushed
the
don/08-10-fix_linter/no-unused-vars_do_not_delete_function_expressions_when_fixing
branch
from
ed50d5b to
a81ce3a
Compare
Base automatically changed from
don/08-10-refactor_linter/no-unused-vars_split_fixer_logic
to
main
August 13, 2024 02:33
graphite-app
bot
deleted the
don/08-10-fix_linter/no-unused-vars_do_not_delete_function_expressions_when_fixing
branch
Merged
Boshen
added a commit
that referenced
this pull request
Aug 15, 2024
## [0.7.2] - 2024-08-15 ### Features - 97e38cd linter: Add fixer for unicorn/prefer-optional-catch-binding (#4867) (heygsc) - 93ae1c7 linter: Eslint-plugin-react jsx-props-no-spread-multi (#4866) (keita hino) - 0a23610 linter: Add fixer for unicorn/prefer-array-flat-map (#4844) (heygsc) - 13c7b1b linter/jsx-a11y: Add fixer for aria-unsupported-elements (#4854) (DonIsaac) - a6195a6 linter/jsx-a11y: Add fixer for anchor-has-content (#4852) (DonIsaac) - 4d28d03 task/website: Support render `subschemas.all_of` (#4800) (mysteryven) ### Bug Fixes - 21f5762 codegen: Minify large numbers (#4889) (Boshen) - a08d7a7 linter/jsx-a11y: Reduce false negatives for html-has-lang (#4855) (DonIsaac) - a81ce3a linter/no-unused-vars: Do not delete function expressions when fixing (#4848) (DonIsaac) ### Documentation - 955a4b4 oxlint: Improve cli doc regarding fix and `-D all` (Boshen) ### Refactor - 56f033c linter: Improve diagnostics for several jsx-a11y rules (#4853) (DonIsaac) - c53c210 linter/no-unused-vars: Split fixer logic into multiple files (#4847) (DonIsaac) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VariableDeclaratorfixer will no longer delete declarations that are initialized to function expressions.