perf(parser): make not at EOF the hot path in Source methods

[overlookmotel]

Reverse if arms in 2 very commonly-called methods in Source so that "not at EOF" is the first branch. This will encourage compiler to treat EOF as the cold branch (which it should be, as we're almost never at EOF).

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[overlookmotel]

• perf(parser): faster decoding unicode escapes in identifiers #4579
• perf(parser): fast path for ASCII when checking char after numeric literal #4577
• perf(parser): make not at EOF the hot path in Source methods #4576 👈
• refactor(parser): convert lexer byte handler for | to a single match #4575
• refactor(parser): convert Lexer::read_minus to a single match #4574
• refactor(parser): convert Lexer::read_left_angle to a single match #4573
• perf(parser): optimize Lexer::hex_digit #4572
• perf(parser): speed up lexing non-decimal numbers #4571
• refactor(parser): add Lexer::consume_2_chars #4569
• refactor(parser): extract u8 not &u8 when iterating over bytes #4568
• refactor(parser): rename function #4566
• refactor(parser): rename vars #4565
• refactor(parser): rename function #4564
• refactor(parser): fetch 2 bytes in ? byte handler #4563
• refactor(parser): shorten lexer code #4562
• perf(parser): use - not saturating_sub #4561
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #4576 will not alter performance

_{Comparing 07-31-perf_parser_make_not_at_eof_the_hot_path_in_source_methods (56ae615) with main (b952942)}

Summary

✅ 32 untouched benchmarks

[graphite-app]

Merge activity

• Jul 30, 11:29 PM EDT: Boshen added this pull request to the Graphite merge queue.
• Jul 30, 11:47 PM EDT: Boshen merged this pull request with the Graphite merge queue.