Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(semantic): add scope tests for IIFEs #4451

Closed

Conversation

DonIsaac
Copy link
Collaborator

@DonIsaac DonIsaac commented Jul 25, 2024

DO NOT MERGE THIS PR UNTIL THE ASSOCIATED ISSUE HAS BEEN RESOLVED!

Reproduction for the bug described in #4452. Part of #4445

Copy link

graphite-app bot commented Jul 25, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-semantic Area - Semantic label Jul 25, 2024
@DonIsaac DonIsaac added the C-bug Category - Bug label Jul 25, 2024
Copy link

codspeed-hq bot commented Jul 25, 2024

CodSpeed Performance Report

Merging #4451 will not alter performance

Comparing don/07-24-test_semantic_add_scope_tests_for_iifes (6f83fc2) with main (fd363d1)

Summary

✅ 32 untouched benchmarks

@Dunqing Dunqing force-pushed the don/07-24-feat_ast_add_astkind_get_container_scope_id branch from a479b23 to fd363d1 Compare July 25, 2024 00:51
@Dunqing Dunqing changed the base branch from don/07-24-feat_ast_add_astkind_get_container_scope_id to main July 25, 2024 00:54
@Dunqing Dunqing force-pushed the don/07-24-test_semantic_add_scope_tests_for_iifes branch from 4dc0a44 to 6f83fc2 Compare July 25, 2024 00:55
@DonIsaac DonIsaac closed this Aug 2, 2024
@overlookmotel
Copy link
Collaborator

overlookmotel commented Aug 2, 2024

@DonIsaac Do these tests pass now? If so, is there any harm in merging this PR, rather than closing it?

@DonIsaac
Copy link
Collaborator Author

DonIsaac commented Aug 2, 2024

@overlookmotel there is one case in them that is passing that I'm not sure should be. I'll let @Dunqing decide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-semantic Area - Semantic C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants