Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): eslint/max-lines #2739

Merged
merged 3 commits into from
Mar 17, 2024

Conversation

andipabst
Copy link
Contributor

@github-actions github-actions bot added the A-linter Area - Linter label Mar 16, 2024
Copy link

codspeed-hq bot commented Mar 17, 2024

CodSpeed Performance Report

Merging #2739 will improve performances by 3.06%

Comparing andipabst:feat/eslint-max-lines (27b9101) with main (78f1adc)

Summary

⚡ 1 improvements
✅ 28 untouched benchmarks

Benchmarks breakdown

Benchmark main andipabst:feat/eslint-max-lines Change
semantic[pdf.mjs] 147.2 ms 142.9 ms +3.06%

@mysteryven
Copy link
Contributor

We may need to run just ready in local to check if there are some broken.

Copy link
Contributor

@mysteryven mysteryven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Learned new things from your implementation, thank you!

@mysteryven mysteryven merged commit 81752b2 into oxc-project:main Mar 17, 2024
20 checks passed
@andipabst andipabst deleted the feat/eslint-max-lines branch March 17, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants