-
-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update bumpalo
crate
#2417
Conversation
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
CodSpeed Performance ReportMerging #2417 will not alter performanceComparing Summary
|
What the hell? It actually hurts the benchmarks (very slightly), rather than improving them. I'll have to look into this. |
Next time you can use |
This is a weird one. It was definitely an improvement for bumpalo. It just replicates what std's Thanks for the tip about git forks. Yes, I'll do that next time. |
It's probably the benchmark not hitting the sweat spots. Let's merge either way. |
OK, thanks for merging. We can probably do better in the parser as building strings now happens in blocks of 32 bytes, so can write each block with 2 x #2295 and #2409 may both require a bit of an overhaul of string handling, so can look at it then. |
Latest version of `bumpalo` includes a couple of performance fixes for `String` (e.g. fitzgen/bumpalo#229) which may help the parser a little.
Latest version of
bumpalo
includes a couple of performance fixes forString
(e.g. fitzgen/bumpalo#229) which may help the parser a little.