-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linter) eslint: no-new-wrappers #2413
Conversation
CodSpeed Performance ReportMerging #2413 will improve performances by 13.2%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this the same as https://github.com/oxc-project/oxc/blob/main/crates/oxc_linter/src/rules/unicorn/new_for_builtins.rs
or very similar?
should we merge the two rules.
Thoughts @Boshen ?
That one does seem a lot more comprehensive and should be preferred. The only reason I can see to include this, is that this falls under |
I think we can accept this rule into Who's got the time to read that wall of eslint rule explanation page :thrug: |
I changed this to |
Part of: oxc-project#479 docs: https://eslint.org/docs/latest/rules/no-new-wrappers I am unsure of what do do with 2 of the eslint tests that use `languageOptions: { globals: { String: "off" } }` and `/* global Boolean:off */`. I've commented them out as of now. --------- Co-authored-by: Boshen <boshenc@gmail.com>
Part of: #479
docs: https://eslint.org/docs/latest/rules/no-new-wrappers
I am unsure of what do do with 2 of the eslint tests that use
languageOptions: { globals: { String: "off" } }
and/* global Boolean:off */
.I've commented them out as of now.