feat(linter): Implement no_this_before_super with cfg

[TzviPM]

Implements eslint/no-this-before-super in #479.

Closes #2279

[codspeed-hq]

CodSpeed Performance Report

Merging #2254 will not alter performance

_{Comparing TzviPM:01-29-feat_linter_Implement_no_this_before_super_with_cfg (366452d) with main (d2b304b)}

Summary

✅ 17 untouched benchmarks

[Boshen]

I checked the error span biome and eslint emits, and combining with the general advice on error spans https://oxc-project.github.io/docs/contribute/linter.html#general-advice

Pin point the error message to the shortest code span

We want the user to focus on the problematic code rather than deciphering the error message to identify which part of the code is erroneous.

The best span would be 1 span pointing to the constructor keyword, and the other error span pointing to the this keyword.

 1 │ class A extends B { constructor() { this.c = 0; } }
   ·                     ___________     ____

The second best is to point to the whole method

 1 │ class A extends B { constructor() { this.c = 0; } }
   ·                     _____________________________

[netlify]

✅ Deploy Preview for oxc canceled.

Name	Link
🔨 Latest commit	366452d
🔍 Latest deploy log	https://app.netlify.com/sites/oxc/deploys/65bef40f233bec0008c9a3d8

[TzviPM]

The best span would be 1 span pointing to the constructor keyword, and the other error span pointing to the this keyword.

Do we have a mechanism for this? My concern is that, say there are 2 uses of this before super(), if we highlight the first usage only, then the user fixes that one and then we show the error again with the second usage, it could be confusing. If we are able to have a diagnostic with multiple spans, we can do that here. Or else should we have multiple diagnostics? I'm happy to start by making sure to use the span for the entire method definition node.

[Boshen]

Here's an example for multiple spans:

oxc/crates/oxc_linter/src/rules/eslint/no_sparse_arrays.rs

Lines 58 to 63 in 0c225a4

	ctx.diagnostic(miette!(
	severity = Severity::Warning,
	labels = violations,
	help = "remove the comma or insert `undefined`",
	"eslint(no-sparse-arrays): Unexpected comma in middle of array"
	));

Feel free to to pick either one depending on your time availableness.

[TzviPM]

I'm going to submit with the option highlighting the whole method for now and open an issue to make it better. I'd like to explore a bit more what the right approach would be; I have a few ideas.

[TzviPM]

I'm going to submit with the option highlighting the whole method for now and open an issue to make it better. I'd like to explore a bit more what the right approach would be; I have a few ideas.

Opened #2290